Commit graph

3,104 commits

Author SHA1 Message Date
72589eb5bf
Version 17.0.0 stable_msys2 stable_macos stable_linux v17.0.0 2026-11-09 09:42:03 +00:00
2fe498b1a0
XMR transaction data integrity checking
Perform a series of pre-signing checks to ensure that the change address in the
transaction belongs to the user’s wallet, that the amount shown is going to the
destination shown, and others, preventing an attacker from stealing funds in the
event the user’s online installation is compromised.

These checks were always performed by the wallet for non-privacy coins but were
regrettably overlooked for Monero. Thus this patch represents an urgent security
fix for Monero users.

It bears mentioning that no system, however secure, can do everything for the
user.  For example, when sending funds to an outside address, the offline
installation has no way of knowing whether the destination and amount are what
the user intended.  A good rule of thumb is to always check the offline signing
summary to ensure that the transaction type is correct and, for transfers, that
the address and amount are correct.
2026-11-09 09:33:34 +00:00
4497478bb1
update documentation 2026-11-09 09:33:34 +00:00
04e8296533
update helpscreen footers 2026-11-09 09:33:34 +00:00
6238e833a1
mmgen-txcreate: XMR compat: exit cleanly if no op specified 2026-11-09 09:33:34 +00:00
a010fa3397
xmrwallet.ops: sign, import: open wallet only if necessary 2026-11-09 09:33:33 +00:00
49bb7e9c9a
amt: fix handling of ‘atomic’ 2026-11-09 09:33:33 +00:00
21f762d668
color: clean up get_terminfo_colors() 2026-11-09 09:33:33 +00:00
88eff0278d
amt: ensure we initialize with Decimal type 2026-11-09 09:33:33 +00:00
e9a5bd4b65
amt: pass kwargs to initializer and dunder methods 2026-11-09 09:33:33 +00:00
7e90f3dd84
nix: add monero.nix 2026-11-09 09:33:33 +00:00
70c29b42c5
cmdtest.py: xmr_watchonly -> xmrwallet_dev 2026-11-09 09:33:33 +00:00
a97e0581d4
whitespace, minor testing fixes 2026-11-09 09:33:28 +00:00
ef61dd104c
new module: proto.xmr.subaddress
Given a master address, account idx and address idx, generate a subaddress.
2026-11-03 10:16:03 +00:00
b47fff4a9f
various cleanups 2026-11-03 10:16:03 +00:00
8dc59c39bf
tool: support addr2pubhex for XMR
Output is concatenated psk + pvk (64 bytes)
2026-11-03 10:16:02 +00:00
e2c5d154f6
tool.coin: docstring cleanups 2026-11-03 10:15:57 +00:00
94816c69fe
XMR autosign: fix post-signing display of transaction data
Data from the unsigned transaction instead of the signed one was being
displayed.  In particular, the transaction ID as shown was incorrect.
2026-11-01 12:51:06 +00:00
e555886312
MoneroWalletDaemon: new offline param; pass test_user to coin daemon 2026-11-01 12:51:06 +00:00
b0ae9851e6
cmdtest.py: new xmr_compat_dev test 2026-11-01 12:51:06 +00:00
0db428d29a
xmrwallet.ops sign, import_outputs: reimplement as proper OpWallet subclasses 2026-11-01 12:51:06 +00:00
a580046ee3
mmgen-xmrwallet: new --no-restart-wallet-daemon option 2026-11-01 12:51:06 +00:00
720d80c19e
xmrwallet OpWallet: new main_starts_daemon attr 2026-11-01 12:51:06 +00:00
7d8d9c8f05
mmgen-xmrwallet: improve args parsing 2026-11-01 12:51:06 +00:00
f4f06bf542
cmdtest: new xmr_watchonly test 2026-11-01 12:51:06 +00:00
efc5931118
autosign: silence duplicate file opening messages for XMR compat 2026-11-01 12:51:05 +00:00
a000ca85d2
minor fixes and cleanups 2026-11-01 12:51:05 +00:00
a1ac5d7602
cmdtest xmrwallet: use namedtuple for user data 2026-11-01 12:51:05 +00:00
7f18131cfd
tx.online.send(): minor fixes 2026-11-01 12:51:01 +00:00
5e326df10f
txsend: improve options handling; tx.online: reimplement send() 2026-10-27 13:30:14 +00:00
8b27679202
tx.tx_proxy.send_tx(): add test param 2026-10-27 13:30:14 +00:00
7e442eadad
proto.eth.params: add multiple_txhex mmcap 2026-10-27 13:30:14 +00:00
4785f2cd36
tx.online: send_with_node() -> rpc_send() 2026-10-27 13:30:14 +00:00
a4b1e1fefe
minor cleanups 2026-10-27 13:30:09 +00:00
96d2c1c36c
proto.btc.rpc.local: rewrite segwit_is_active() 2026-10-26 13:36:48 +00:00
3555ef3e54
util: new test_socket() utility function 2026-10-26 13:36:48 +00:00
f77b1b73f4
MSWin fixes 2026-10-26 13:36:48 +00:00
988e621712
various exception-related changes and cleanups 2026-10-26 13:36:48 +00:00
1a3f11ba51
ruff exceptions: various 2026-10-26 13:36:48 +00:00
b3e42701c5
minor changes, fixes and cleanups 2026-10-26 13:36:47 +00:00
c2ffb537ca
ruff exceptions: ConnectionError 2026-10-26 13:36:47 +00:00
d2bd996abe
ruff exceptions: KeyError 2026-10-26 13:36:47 +00:00
545a653d2c
ruff exceptions: os.makedirs(), sh.rmtree() 2026-10-26 13:36:47 +00:00
6ae440da35
ruff exceptions: FileNotFoundError 2026-10-26 13:36:47 +00:00
b43fc87e3a
ruff: except: -> except Exception: 2026-10-26 13:36:41 +00:00
779133d203
support Reth v2.8.1 2026-10-25 10:11:14 +00:00
e730ae794b
cmdtest.py xmrswap: add vault address check 2026-10-25 10:11:14 +00:00
c0af5bc2b5
test suite thornode: improve inbound address creation 2026-10-25 10:11:14 +00:00
0083ca1590
tx.new_swap: qd -> qc, minor cleanup 2026-10-25 10:11:14 +00:00
e7d8e8993b
XMR compat: minor display fixes 2026-10-25 10:11:14 +00:00