tx.new, tw.addresses: cleanups, minor fix

mmgen/tw/addresses.py

@@ -269,6 +269,7 @@ class TwAddresses(TwView):
 				yield (sid_save, sid_range(bot, n-1))
 
 		assert self.sort_key == 'twmmid'
+		assert self.reverse == False
 
 		if not hasattr(self,'_sid_ranges'):
 			self._sid_ranges = dict(gen_sid_ranges())
@@ -313,6 +314,7 @@ class TwAddresses(TwView):
 				n = (top + bot) >> 1
 
 		assert self.sort_key == 'twmmid'
+		assert self.reverse == False
 
 		data = self.data
 		start = get_start(
@@ -325,7 +327,8 @@ class TwAddresses(TwView):
 					if not d.recvd:
 						return d
 				else:
-					return False
+					break
+			return False
 
 	def get_change_address_by_addrtype(self,mmtype):
 		"""

mmgen/tx/new.py

@@ -189,8 +189,6 @@ class New(Base):
 
 			from ..tw.addresses import TwAddresses
 			al = await TwAddresses(self.proto,get_data=True)
-			al.reverse = False
-			al.do_sort('twmmid')
 
 			if is_mmgen_addrtype(self.proto,arg):
 				arg = MMGenAddrType(self.proto,arg)