mmgen/mmgen-wallet
1
0
Fork 0
Code Issues Pull requests Projects Releases 28 Packages Wiki Activity

Version 0.11.0c - bugfix subrelease

Browse source 
- correctly handle privkey edge case
- correctly initialize altcoin trust levels

The edge case had a one in 2^127 chance of occurring per generated address,
so was *very* unlikely to have caused a problem for anyone.

The trust level bug caused an incorrect trust level to be displayed in altcoin
warning messages.  If you generate altcoin keys/addresses, an upgrade is
recommended.

MMGen's "trusted" altcoins BCH, LTC, ETH, ETC and XMR were not affected by the
bug.
This commit is contained in:
The MMGen Project 2019-11-03 10:42:58 +00:00
commit a98fef75a6
Signed by: mmgen
GPG key ID: 3F8B1861E32B7DA2
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
mmgen/protocol.py
View file

@ -119,8 +119,8 @@ class BitcoinProtocol(MMGenObject):
elif pk == cls.secp256k1_ge: # ditto
ydie(3,'Private key == secp256k1_ge!')
else:
ymsg('Warning: private key is greater than secp256k1 group order!:\n {}'.format(hexpriv))
return '{:064x}'.format(pk % cls.secp256k1_ge).encode()
ymsg('Warning: private key >secp256k1 group order was reduced')
return '{:064x}'.format(pk % cls.secp256k1_ge)
@classmethod
def hex2wif(cls,hexpriv,pubkey_type,compressed): # PrivKey
@ -366,7 +366,7 @@ class ZcashProtocol(BitcoinProtocolAddrgen):
if pubkey_type == 'zcash_z':
return '{:02x}'.format(int(hexpriv[:2],16) & 0x0f) + hexpriv[2:]
else:
return hexpriv
return super(cls,cls).preprocess_key(hexpriv,pubkey_type)
@classmethod
def pubhash2addr(cls,pubkey_hash,p2sh):
@ -473,9 +473,13 @@ def init_genonly_altcoins(usr_coin,trust_level=None):
if usr_coin.lower() in CoinProtocol.coins:
return CoinProtocol.coins[usr_coin.lower()][2]
usr_coin = usr_coin.upper()
mn_coins = [e[1] for e in ci.coin_constants['mainnet'] if e[6] != -1]
if usr_coin not in mn_coins: return None
trust_level = ci.coin_constants['mainnet'][mn_coins.index(usr_coin)][6]
usr_entry = [e for e in ci.coin_constants['mainnet'] if e[1] == usr_coin]
if not usr_entry:
raise ValueError('Coin {} not recognized'.format(usr_coin))
usr_entry = usr_entry[0]
if usr_entry[6] == -1:
raise ValueError('Coin {} ({}) not supported'.format(usr_coin,usr_entry[0]))
trust_level = usr_entry[6]
data = {}
for k in ('mainnet','testnet'):
data[k] = [e for e in ci.coin_constants[k] if e[6] >= trust_level]